ImmutableDB: migrate XXXXX.epoch to XXXXX.chunk #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
force-pushed
the
mrBliss/migrate-epoch-to-chunk
branch
from
05c9416
to
3f02be0
Compare
mrBliss
commented
Apr 16, 2020
ouroboros-consensus/src/Ouroboros/Consensus/Storage/ImmutableDB/Impl/Validation.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/Storage/ImmutableDB/Impl/Validation.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/Storage/ImmutableDB/Types.hs
Outdated
Show resolved
Hide resolved
edsko
approved these changes
Apr 16, 2020
mrBliss
force-pushed
the
mrBliss/migrate-epoch-to-chunk
branch
2 times, most recently
from
3624f24
to
4a8dbf2
Compare
|
I tested this with |
mrBliss
force-pushed
the
mrBliss/migrate-epoch-to-chunk
branch
from
4a8dbf2
to
c12d126
Compare
|
bors merge |
Timed out |
mrBliss
force-pushed
the
mrBliss/migrate-epoch-to-chunk
branch
from
c12d126
to
5deac3f
Compare
|
bors merge |
Build failed |
Now all the definitions mentioning "epoch", "primary", and "secondary" are close together, so that when changing one of them, the chances are higher you update all instances of it.
In particular, passing it a string (`Text` actually) everywhere. Instead, introduce and use `fsPathChunkFile`, `fsPathPrimaryIndexFile`, and `fsPathSecondaryIndexFile`. Having them defined in a single place will also make it easier to change the actual filenames in the future.
Fixes #1755. On startup, the ImmutableDB will rename any XXXXX.epoch files to XXXXX.chunk before validation.
mrBliss
force-pushed
the
mrBliss/migrate-epoch-to-chunk
branch
2 times, most recently
from
f93fd05
to
91113da
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1755.
On startup, the ImmutableDB will rename any XXXXX.epoch files to XXXXX.chunk before validation.