Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes after splitting consensus API #1959

Merged
merged 7 commits into from
Apr 16, 2020
Merged

Conversation

coot
Copy link
Contributor

@coot coot commented Apr 16, 2020

These changes I came up with when I started updating cardano-node repository.

Related to #1950

  • supported versions should be a non empty list
  • ClientCodecs: node-to-client protocol codecs
  • defaultCodec: don't impose IOLike where MonadST is enough
  • added localStateQueryClientNull
  • Added utililty functions for folding multiple Versions
  • NodeToClient.versionedNodeToClientProtocols

@coot coot added networking consensus issues related to ouroboros-consensus labels Apr 16, 2020
@coot coot requested review from edsko and MarcFontaine April 16, 2020 05:35
Copy link
Contributor

@edsko edsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice, I knew that passing cfg :: BlockConfig blk would be useful for a "proper" ClientCodecs :)

@coot
Copy link
Contributor Author

coot commented Apr 16, 2020

The clients depend on TopLeevelConfig because of nodeNetworkMagic.

@coot
Copy link
Contributor Author

coot commented Apr 16, 2020

bors merge

iohk-bors bot added a commit that referenced this pull request Apr 16, 2020
1959: Various changes after splitting consensus API r=coot a=coot

These changes I came up with when I started updating `cardano-node` repository.

Related to #1950

- supported versions should be a non empty list
- ClientCodecs: node-to-client protocol codecs
- defaultCodec: don't impose IOLike where MonadST is enough
- added localStateQueryClientNull
- Added utililty functions for folding multiple Versions
- NodeToClient.versionedNodeToClientProtocols


Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
@coot
Copy link
Contributor Author

coot commented Apr 16, 2020

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 16, 2020

Canceled

…nt.hs

Co-Authored-By: Thomas Winant <thomas@well-typed.com>
@coot
Copy link
Contributor Author

coot commented Apr 16, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 16, 2020

@iohk-bors iohk-bors bot merged commit a623120 into master Apr 16, 2020
@iohk-bors iohk-bors bot deleted the coot/local-state-query branch April 16, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants