-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various changes after splitting consensus API #1959
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A utility function which creates a singleton 'Versions' out of 'NodeToClientprotocols' for a given 'NodeToClientVersion'
Provide codecs which deserialise blocks in chain-sync protocol.
edsko
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice, I knew that passing cfg :: BlockConfig blk
would be useful for a "proper" ClientCodecs
:)
The clients depend on |
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 16, 2020
1959: Various changes after splitting consensus API r=coot a=coot These changes I came up with when I started updating `cardano-node` repository. Related to #1950 - supported versions should be a non empty list - ClientCodecs: node-to-client protocol codecs - defaultCodec: don't impose IOLike where MonadST is enough - added localStateQueryClientNull - Added utililty functions for folding multiple Versions - NodeToClient.versionedNodeToClientProtocols Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
mrBliss
reviewed
Apr 16, 2020
ouroboros-consensus/src/Ouroboros/Consensus/Network/NodeToClient.hs
Outdated
Show resolved
Hide resolved
bors r- |
Canceled |
…nt.hs Co-Authored-By: Thomas Winant <thomas@well-typed.com>
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes I came up with when I started updating
cardano-node
repository.Related to #1950