New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PParams field to ShelleyGenesis data structure #2040
Conversation
@nc6 should review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, at this point, I wonder if we should just have the entire PParams
structure in genesis. I basically overrode only those fields that were necessary to get a test running, otherwise using emptyPParams
. But really there's no justification for emptyPParams
use outside of testing, and in a Shelley testnet we should be thinking about all of the parameters.
So I'm happy with merging this PR if there's a specific need for these parameters now, but otherwise let's actually pull in the full set of protocol parameters.
This was just one we discovered we needed. But you're right, we should just pull in the full set. |
fe58c5b
to
e6b8cc3
Compare
e6b8cc3
to
6c184f2
Compare
6c184f2
to
20b773f
Compare
bors r+ |
When spinning up a Shelley node, it will be useful to be able to specify these in the genesis configuration.