Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PParams field to ShelleyGenesis data structure #2040

Merged
merged 1 commit into from May 8, 2020

Conversation

intricate
Copy link
Contributor

@intricate intricate commented May 6, 2020

When spinning up a Shelley node, it will be useful to be able to specify these in the genesis configuration.

@intricate intricate self-assigned this May 6, 2020
@intricate intricate added the consensus issues related to ouroboros-consensus label May 6, 2020
@edsko edsko requested a review from nc6 May 6, 2020 05:28
@edsko
Copy link
Contributor

edsko commented May 6, 2020

@nc6 should review this.

Copy link
Contributor

@nc6 nc6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, at this point, I wonder if we should just have the entire PParams structure in genesis. I basically overrode only those fields that were necessary to get a test running, otherwise using emptyPParams. But really there's no justification for emptyPParams use outside of testing, and in a Shelley testnet we should be thinking about all of the parameters.

So I'm happy with merging this PR if there's a specific need for these parameters now, but otherwise let's actually pull in the full set of protocol parameters.

@dcoutts
Copy link
Contributor

dcoutts commented May 6, 2020

So I'm happy with merging this PR if there's a specific need for these parameters now, but otherwise let's actually pull in the full set of protocol parameters.

This was just one we discovered we needed. But you're right, we should just pull in the full set.

@intricate intricate force-pushed the intricate/minfee-factors-shelleygenesis branch from fe58c5b to e6b8cc3 Compare May 8, 2020 05:05
@intricate
Copy link
Contributor Author

@nc6 @dcoutts: As suggested, I've now added a field toShelleyGenesis for PParams.

@intricate intricate requested a review from nc6 May 8, 2020 05:06
@intricate intricate force-pushed the intricate/minfee-factors-shelleygenesis branch from e6b8cc3 to 6c184f2 Compare May 8, 2020 05:07
@intricate intricate changed the title Add fields to ShelleyGenesis for the linear and constant minfee calculation factors Add PParams field to ShelleyGenesis data structure May 8, 2020
@intricate intricate force-pushed the intricate/minfee-factors-shelleygenesis branch from 6c184f2 to 20b773f Compare May 8, 2020 15:22
@intricate
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 8, 2020

@iohk-bors iohk-bors bot merged commit b9465d2 into master May 8, 2020
@iohk-bors iohk-bors bot deleted the intricate/minfee-factors-shelleygenesis branch May 8, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants