Construct the initial stake snapshot only using addresses that can have stake #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
force-pushed
the
intricate/stake-distr-filter-addrs
branch
from
938aa2d
to
22fb394
Compare
dcoutts
requested changes
May 7, 2020
ouroboros-consensus-shelley/src/Ouroboros/Consensus/Shelley/Node.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-shelley/src/Ouroboros/Consensus/Shelley/Node.hs
Outdated
Show resolved
Hide resolved
intricate
force-pushed
the
intricate/stake-distr-filter-addrs
branch
from
22fb394
to
3deedd7
Compare
intricate
force-pushed
the
intricate/stake-distr-filter-addrs
branch
from
3deedd7
to
8205f94
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, an
errorwould be thrown when attempting to allocate funds in the genesis UTxO for Shelley addresses withStakeRefNullstake credential references. We would also improperly filter the kinds of addresses that can have stake when constructing the initial stake distribution snapshot. For example, we were mistakenly including Byron bootstrap addresses in the initial stake distribution snapshot.