Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetUTxO to the shelley QueryLedger instance #2110

Merged
merged 1 commit into from May 18, 2020
Merged

Add GetUTxO to the shelley QueryLedger instance #2110

merged 1 commit into from May 18, 2020

Conversation

Jimbo4350
Copy link
Contributor

No description provided.

mrBliss
mrBliss suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@mrBliss mrBliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for not using GetFilteredUTxO Set.empty on the node side?

ouroboros-consensus-shelley/src/Ouroboros/Consensus/Shelley/Ledger/Ledger.hs Show resolved Hide resolved
@Jimbo4350
Copy link
Contributor Author

What's the reason for not using GetFilteredUTxO Set.empty on the node side?

getFilteredUTxO will return an empty UTxO if an empty set is passed.

@mrBliss
Copy link
Contributor

mrBliss commented May 18, 2020

What's the reason for not using GetFilteredUTxO Set.empty on the node side?

getFilteredUTxO will return an empty UTxO if an empty set is passed.

Ah 🙂

@Jimbo4350 Jimbo4350 force-pushed the jordan/update-shelley-queryledger-instance branch from 5b78c1f to b978106 Compare May 18, 2020 14:15
@Jimbo4350 Jimbo4350 force-pushed the jordan/update-shelley-queryledger-instance branch from b978106 to ad2548e Compare May 18, 2020 14:24
@Jimbo4350
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 18, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 7c0e72c into master May 18, 2020
@iohk-bors iohk-bors bot deleted the jordan/update-shelley-queryledger-instance branch May 18, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrBliss mrBliss mrBliss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jimbo4350 @mrBliss