threadDelay & registerDelay - unbounded delays #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
reviewed
May 22, 2020
|
@mrBliss there's a CI failure in Byron test suite: https://hydra.iohk.io/build/2717445/nixlog/3 |
If |
|
Locally, it run fine: |
dcoutts
approved these changes
May 26, 2020
For delays smaler than 'maxBound :: Int', we use 'Control.Monad.STM.registerDelay'; for larger delays we start a monitoring thread which will update the returned 'TVar' (re-using the default implementation).
|
bors merge |
coot
added a commit
that referenced
this pull request
May 16, 2022
2135: threadDelay & registerDelay - unbounded delays r=coot a=coot This PR updates both `threadDelay` and `registerDelay`. Both accept `DiffTime`, and they should be safe. `threadDelay` is easy, since it's a synchronous operation; `registerDelay` is more tricky as the returned `TVar` must be updated asynchronously. For delays smaller than `maxBound :: Int` we reuse the original `STM` implenetation, for larger delays we use the default 'MonadTimer` implementation (which starts a thread to update the `TVar`). - registerDelay - accept unbounded delays - threadDaley - accept unbounded delays Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
coot
pushed a commit
to input-output-hk/typed-protocols
that referenced
this pull request
May 16, 2022
2162: Undo MonadDelay wrapper r=mrBliss a=kderme After IntersectMBO/ouroboros-network#2135 the wrapper is no longer needed. Undoes IntersectMBO/ouroboros-network#2095 Co-authored-by: kderme <k.dermenz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates both
threadDelayandregisterDelay. Both acceptDiffTime, and they should be safe.threadDelayis easy, since it's a synchronous operation;registerDelayis more tricky as the returnedTVarmust be updatedasynchronously. For delays smaller than
maxBound :: Intwe reuse the originalSTMimplenetation, for larger delays we use the default 'MonadTimerimplementation (which starts a thread to update theTVar`).