Pass only BlockConfig to nodeStartTime/NetworkMagic/ProtocolMagicId #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsko
approved these changes
May 26, 2020
None of the implementations ever needed more than the `BlockConfig`. So replace `TopLevelConfig` with `BlockConfig` in those methods. This makes it easier to define those methods for a non-degenerate hard-fork, where we can't always project out an era-specific `TopLevelConfig` from the hard-fork one, because of the partial configs. We can trivially project out the era-specific `BlockConfig`s, though.
mrBliss
force-pushed
the
mrBliss/node-blockconfig
branch
from
ad273bb
to
ad7f0b1
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the implementations ever needed more than the
BlockConfig. Soreplace
TopLevelConfigwithBlockConfigin those methods.This makes it easier to define those methods for a non-degenerate hard-fork,
where we can't always project out an era-specific
TopLevelConfigfrom thehard-fork one, because of the partial configs. We can trivially project out
the era-specific
BlockConfigs, though.