Move nodeBlockMatchesHeader and nodeHeaderIsEBB to GetHeader #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: create a proper, strict type for UPDATE: let's do that later. Such a refactoring would be good, but it doesn't benefit the hard fork combinator. |
mrBliss
force-pushed
the
mrBliss/getHeader
branch
from
6acafea
to
ce2bf54
Compare
mrBliss
commented
May 28, 2020
ouroboros-consensus/src/Ouroboros/Consensus/Storage/ChainDB/Impl/VolDB.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/test-storage/Test/Ouroboros/Storage/TestBlock.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/test-storage/Test/Ouroboros/Storage/TestBlock.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/test-storage/Test/Ouroboros/Storage/ImmutableDB/StateMachine.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/test-storage/Test/Ouroboros/Storage/ImmutableDB/StateMachine.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/test-storage/Test/Ouroboros/Storage/ChainDB/StateMachine.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/test-storage/Test/Ouroboros/Storage/ChainDB/StateMachine.hs
Outdated
Show resolved
Hide resolved
edsko
approved these changes
May 28, 2020
This is another step in the direction of emptying the `RunNode` sin bin. Moreover, the hard-fork combinator can now provide straightforward implementations for these methods.
mrBliss
force-pushed
the
mrBliss/getHeader
branch
from
ce2bf54
to
0c4c7ac
Compare
|
bors merge |
coot
pushed a commit
that referenced
this pull request
May 16, 2022
2158: Move nodeBlockMatchesHeader and nodeHeaderIsEBB to GetHeader r=mrBliss a=mrBliss This is another step in the direction of emptying the `RunNode` sin bin. Moreover, the hard-fork combinator can now provide straightforward implementations for these methods. Co-authored-by: Thomas Winant <thomas@well-typed.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step in the direction of emptying the
RunNodesin bin.Moreover, the hard-fork combinator can now provide straightforward
implementations for these methods.