Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the safe zone _just_ enough #2165

Merged
merged 6 commits into from
May 28, 2020
Merged

Increase the safe zone _just_ enough #2165

merged 6 commits into from
May 28, 2020

Conversation

edsko
Copy link
Contributor

@edsko edsko commented May 28, 2020

No description provided.

edsko added 5 commits May 28, 2020 11:55
@edsko
Better documentation of EraSummary invariants
ef64d5c
@edsko
Discuss translation around the transition point.
e017bd7
@edsko
Query DSL
4ebe488 
This allows us to be precise about exactly where we have tight bounds, and
where we don't.
@edsko
Return slots left in epoch
610a5a4 
This makes slot/time and slot/epoch conversions entirely uniform.
@edsko
Relax upper bounds
429b530 
This doesn't change the tests, because they ask for era parameters, and so they
cannot take advantage of the rlaxed bounds.

Passes 1M tests.
@edsko
Copy link
Contributor Author

edsko commented May 28, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 28, 2020

👎 Rejected by too few approved reviews

@mrBliss mrBliss self-requested a review May 28, 2020 14:46
mrBliss
mrBliss approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@mrBliss mrBliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, very clear!

@edsko
Copy link
Contributor Author

edsko commented May 28, 2020

bors merge

1 similar comment
@edsko
Copy link
Contributor Author

edsko commented May 28, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 28, 2020

Already running a review

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 28, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit b50c4b0 into master May 28, 2020
@iohk-bors iohk-bors bot deleted the edsko/relax-find branch May 28, 2020 15:10
coot pushed a commit that referenced this pull request May 16, 2022
@iohk-bors @edsko
Merge #2165
1d80e71 
2165: Increase the safe zone _just_ enough r=edsko a=edsko



Co-authored-by: Edsko de Vries <edsko@well-typed.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrBliss mrBliss mrBliss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edsko @mrBliss