Introduce CannotLead
#2169
Merged
Introduce CannotLead
#2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the next step a bit cleaner.
This will be required for the next commit.
This was referenced May 29, 2020
edsko
commented
May 29, 2020
ouroboros-consensus/src/Ouroboros/Consensus/Protocol/LeaderSchedule.hs
Outdated
Show resolved
Hide resolved
mrBliss
approved these changes
May 29, 2020
Before when a node had an outdated (or conversely not-yet-active) it had no way to indicate that it was a leader but that it couldn't lead before the key was wrong. We now distinguish these two cases, although we don't yet take advantage of this. We should: both PBFT and TPraos should _check_ if the key matches the delegation state, and if not, say that they cannot lead, rather than produce an invalid block.
edsko
force-pushed
the
edsko/introduce-cannot-lead
branch
from
6090277
to
76dd3b8
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when a node had an outdated (or conversely not-yet-active) it had no way to indicate that it was a leader but that it couldn't lead before the key was wrong. We now distinguish these two cases, although we don't yet take advantage of this. We should: both PBFT and TPraos should check if the key matches the delegation state, and if not, say that they cannot lead, rather than produce an invalid block.