Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byron: check if key is okay in checkIsLeader #2172

Closed
edsko opened this issue May 29, 2020 · 1 comment
Closed

Byron: check if key is okay in checkIsLeader #2172

edsko opened this issue May 29, 2020 · 1 comment
Assignees
@nc6
Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node consensus issues related to ouroboros-consensus
Milestone
S14 2020-06-04

Comments

@edsko
Copy link
Contributor

edsko commented May 29, 2020

See #2169.

Marking this as high priority because logging information about invalid blocks being produced is terrifying, whereas messages about keys being out of date just means PEBKAC. (A report about invalid blocks came in only today, so it's important we address this soon.)

In addition, the construction of invalid blocks is causing trouble for @nfrisby 's tests; doing this will hopefully avoid the hack in #2048 -- indeed, we should be able to avoid the whole "should we do the production of this EBB?" thing.
@edsko edsko added consensus issues related to ouroboros-consensus priority high byron Required for a Byron mainnet: replace the old core nodes with cardano-node labels May 29, 2020
@edsko edsko added this to the S14 2020-06-04 milestone May 29, 2020
@edsko edsko assigned edsko and nc6 and unassigned edsko May 29, 2020
@edsko edsko mentioned this issue May 29, 2020
Closed
@nc6 nc6 mentioned this issue May 29, 2020
Merged
@edsko edsko mentioned this issue Jun 1, 2020
Closed
iohk-bors bot added a commit that referenced this issue Jun 1, 2020
@iohk-bors @nc6
@nfrisby @edsko
Merge #2176
cd88147 
2176: Add PBFT CannotLead checks r=edsko a=nc6

- Check that we are the current delegate of the genesis key
- Check that more blocks than the singing threshold have not been issued.

Addresses #2172

Co-authored-by: Nicholas Clarke <nick@topos.org.uk>
Co-authored-by: Nicolas Frisby <nick.frisby@iohk.io>
Co-authored-by: Edsko de Vries <edsko@well-typed.com>
iohk-bors bot added a commit that referenced this issue Jun 1, 2020
@iohk-bors @nc6
@nfrisby @edsko
Merge #2176
968cf18 
2176: Add PBFT CannotLead checks r=edsko a=nc6

- Check that we are the current delegate of the genesis key
- Check that more blocks than the singing threshold have not been issued.

Addresses #2172

Co-authored-by: Nicholas Clarke <nick@topos.org.uk>
Co-authored-by: Nicolas Frisby <nick.frisby@iohk.io>
Co-authored-by: Edsko de Vries <edsko@well-typed.com>
@edsko
Copy link
Contributor Author

edsko commented Jun 1, 2020

Closed in #2176 .

@edsko edsko closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nc6 nc6

Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node consensus issues related to ouroboros-consensus
Projects
None yet
Milestone
S14 2020-06-04
Development

No branches or pull requests
2 participants
@edsko @nc6