Split off CodecConfig from ConfigSupportsNode #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
force-pushed
the
mrBliss/split-off-codec-config
branch
from
545e7f1
to
92315dd
Compare
edsko
approved these changes
Jun 1, 2020
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 1, 2020
2185: Split off CodecConfig from ConfigSupportsNode r=mrBliss a=mrBliss In the future, we'll need `CodecConfig` and `getCodecConfig` in some contexts where we don't care about the other methods of `ConfigSupportsNode`, e.g., in the storage layer. Co-authored-by: Thomas Winant <thomas@well-typed.com>
Build failed |
In the future, we'll need `CodecConfig` and `getCodecConfig` in some contexts where we don't care about the other methods of `ConfigSupportsNode`, e.g., in the storage layer.
mrBliss
force-pushed
the
mrBliss/split-off-codec-config
branch
from
92315dd
to
a806f01
Compare
|
bors merge |
coot
pushed a commit
that referenced
this pull request
May 16, 2022
2185: Split off CodecConfig from ConfigSupportsNode r=mrBliss a=mrBliss In the future, we'll need `CodecConfig` and `getCodecConfig` in some contexts where we don't care about the other methods of `ConfigSupportsNode`, e.g., in the storage layer. Co-authored-by: Thomas Winant <thomas@well-typed.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, we'll need
CodecConfigandgetCodecConfigin some contextswhere we don't care about the other methods of
ConfigSupportsNode, e.g., inthe storage layer.