Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inrease block header size estimate to 1400 #2206

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Inrease block header size estimate to 1400 #2206

merged 1 commit into from
Jun 4, 2020

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Jun 4, 2020

The manuall block header size estimate is too small for Shelley.

@karknu
Inrease block header size estimate to 1400
f063faa 
The manuall block header size estimate is too small for Shelley.
@karknu karknu requested review from coot and dcoutts June 4, 2020 09:30
@karknu
Copy link
Contributor Author

karknu commented Jun 4, 2020

Fixes #2188 .

coot
coot approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcoutts
Copy link
Contributor

dcoutts commented Jun 4, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 4, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 7b140f7 into master Jun 4, 2020
@iohk-bors iohk-bors bot deleted the karknu/maxBlockHeader branch June 4, 2020 10:31
@karknu karknu mentioned this pull request Jun 5, 2020
Closed
coot pushed a commit that referenced this pull request May 16, 2022
@iohk-bors @karknu
Merge #2206
c5d889a 
2206: Inrease block header size estimate to 1400 r=dcoutts a=karknu

The manuall block header size estimate is too small for Shelley.

Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@dcoutts dcoutts dcoutts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karknu @dcoutts @coot