Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 2 * k with the stability window in ledgerViewForecastAt #2220

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Replace 2 * k with the stability window in ledgerViewForecastAt #2220

merged 1 commit into from
Jun 5, 2020

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented Jun 4, 2020 •
edited

For Praos we should be using the stability window (3*k/f) rather than the
Ouroboros Classic value of 2*k.

@dcoutts
Replace 2 * k with the stability window in ledgerViewForecastAt
622e3f4 
For Praos we should be using the stability window (3*k/f) rather than the
Ouroboros Classic value of 2*k.
@dcoutts dcoutts requested a review from nfrisby June 4, 2020 23:57
@dcoutts
Copy link
Contributor Author

dcoutts commented Jun 4, 2020

For an isolated node that is not configured to make blocks:

Before:

No ledger view at slot 20

Which corresponded to 2 * k, for k = 10.

After:

No ledger view at slot 300

Which corresponded to 3 * k / f, for k = 10, f = 1/10.

nfrisby
nfrisby approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff replaces occurrences of 2 * k by SL.stabilityWindow. LGTM!

JaredCorduan
JaredCorduan approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dcoutts
Copy link
Contributor Author

dcoutts commented Jun 5, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 5, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 16bca08 into master Jun 5, 2020
@iohk-bors iohk-bors bot deleted the dcoutts/fix-shelley-eraSafeZone branch June 5, 2020 00:15
This was referenced Jun 5, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@nfrisby nfrisby nfrisby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcoutts @JaredCorduan @nfrisby