Keep Alive protocol #2251
Merged
Keep Alive protocol #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karknu
force-pushed
the
karknu/keep-alive
branch
from
a417c84
to
d52ad4b
Compare
mrBliss
reviewed
Jun 12, 2020
ouroboros-consensus/ouroboros-consensus-test-infra/src/Test/ThreadNet/Network.hs
Outdated
Show resolved
Hide resolved
Closed
karknu
force-pushed
the
karknu/keep-alive
branch
from
d52ad4b
to
00516c3
Compare
karknu
force-pushed
the
karknu/keep-alive
branch
from
e36950b
to
4755ced
Compare
|
I was going to suggest we used a technique such as https://github.com/input-output-hk/ouroboros-network/blob/6507ec6eb08e75925e9c3072a11db84e226bf706/io-sim-classes/src/Control/Monad/Class/MonadTimer.hs#L125-L136 <https://github.com/input-output-hk/ouroboros-network/blob/6507ec6eb08e75925e9c3072a11db84e226bf706/io-sim-classes/src/Control/Monad/Class/MonadTimer.hs#L125-L136>
Perhaps export maxDelay as an attribute of MonadTImer ?
… On 15 Jun 2020, at 20:47, Karl Knutsson ***@***.***> wrote:
@karknu commented on this pull request.
In ouroboros-network/src/Ouroboros/Network/DeltaQ.hs <#2251 (comment)>:
> @@ -269,3 +275,21 @@ gsvRequestResponseDuration PeerGSV{outboundGSV, inboundGSV}
gsvTrailingEdgeArrive outboundGSV reqSize
<> gsvTrailingEdgeArrive inboundGSV respSize
+
+defaultGSV :: PeerGSV
+defaultGSV = PeerGSV { outboundGSV, inboundGSV }
+ where
+ default_g = 3600 -- 1h, start with an unreasonable large G.
There isn't a maxBound for DiffTime.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#2251 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB75OFINWLGQHMY737Y7W3RWZ3EHANCNFSM4N4FKB5Q>.
|
|
That is a great idea. I will define a local |
karknu
force-pushed
the
karknu/keep-alive
branch
7 times, most recently
from
9d35129
to
e4991fb
Compare
|
Part of #1416 |
karknu
force-pushed
the
karknu/keep-alive
branch
4 times, most recently
from
e317925
to
a69f143
Compare
karknu
force-pushed
the
karknu/keep-alive
branch
4 times, most recently
from
f6ed7c2
to
dfa6cfe
Compare
karknu
force-pushed
the
karknu/keep-alive
branch
4 times, most recently
from
040548a
to
042470e
Compare
I know, I needed it for testing which was done with a 1.18.0 node. |
coot
reviewed
Aug 10, 2020
ouroboros-network/src/Ouroboros/Network/BlockFetch/ClientRegistry.hs
Outdated
Show resolved
Hide resolved
coot
reviewed
Aug 11, 2020
ouroboros-consensus/src/Ouroboros/Consensus/Network/NodeToNode.hs
Outdated
Show resolved
Hide resolved
karknu
force-pushed
the
karknu/keep-alive
branch
from
3e6743a
to
f2aab06
Compare
coot
requested changes
Aug 11, 2020
karknu
force-pushed
the
karknu/keep-alive
branch
from
f2aab06
to
64450c3
Compare
It makes reviewing this PR harder for me, because that commit touches many consensus files, but I have to ignore these changes. Moreover, I believe it's the cause of the merge conflicts. |
karknu
force-pushed
the
karknu/keep-alive
branch
2 times, most recently
from
d203902
to
cc3709c
Compare
The PR is intended to be reviewed one commit at the time, but in you're case I guess you're mostly interested in reviewing the changes at the consensus layer so that doesn't help. I've rebased on top of master and the extra commit is no longer there. |
karknu
force-pushed
the
karknu/keep-alive
branch
from
cc3709c
to
eae882c
Compare
karknu
force-pushed
the
karknu/keep-alive
branch
from
eae882c
to
e5f599f
Compare
mrBliss
suggested changes
Aug 11, 2020
ouroboros-consensus/src/Ouroboros/Consensus/Network/NodeToNode.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/ouroboros-consensus-test-infra/src/Test/ThreadNet/Network.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/ouroboros-consensus-test-infra/src/Test/ThreadNet/Network.hs
Outdated
Show resolved
Hide resolved
karknu
force-pushed
the
karknu/keep-alive
branch
from
fd753d4
to
0b57047
Compare
mrBliss
approved these changes
Aug 11, 2020
Implement smooth switching from slower to faster peers by temporarily ignoring the concurrency limit for faster peers. This lets faster peers starve out slower peers and makes it possible to switch peers without first having to wait for all outstanding requests to the slower peers to finish.
Give peers with outstanding bytes an advantage when ordering peers.
Add a random cookie to keep-alive messages so that a rouge responder can't send a MsgKeepAliveResponse before it has read the MsgKeepAlive.
Temporarily increase the keep-alive timeout to 60s.
karknu
force-pushed
the
karknu/keep-alive
branch
from
eb35856
to
29b0272
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.