Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonadTimer: export DiffTime #2775

Merged
merged 2 commits into from Nov 24, 2020
Merged

MonadTimer: export DiffTime #2775

merged 2 commits into from Nov 24, 2020

Conversation

coot
Copy link
Contributor

@coot coot commented Nov 24, 2020

Also remove time dependency from ouroboros-network.

@coot coot requested a review from dcoutts November 24, 2020 15:38
dcoutts
dcoutts approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot force-pushed the coot/MonadTimer-export-DiffTime branch from c1c4ffb to 9832301 Compare November 24, 2020 18:34
@coot
MonadTimer: export DiffTime
e03ae05 
Also remove `time` dependency from `ouroboros-network`.
@coot
MonadTime: export NominalDiffTime, diffUTCTime and addUTCTime
420970c 
We export 'DiffTime' and its action on 'Time' through 'addTime'.  We
also export 'UTCTime', but not 'NominalDiffTime' and its action on it.
This patch fixes this discrepency.
@coot coot force-pushed the coot/MonadTimer-export-DiffTime branch from 9832301 to 420970c Compare November 24, 2020 18:56
@coot
Copy link
Contributor Author

coot commented Nov 24, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 24, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit ff2bfcd into master Nov 24, 2020
@iohk-bors iohk-bors bot deleted the coot/MonadTimer-export-DiffTime branch November 24, 2020 21:06
coot added a commit that referenced this pull request May 16, 2022
@iohk-bors @coot
Merge #2775
dc5a95f 
2775: MonadTimer: export DiffTime r=coot a=coot

Also remove `time` dependency from `ouroboros-network`.

Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts approved these changes

Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coot @dcoutts