-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LocalStQuery and ChainSync clients: aditional monadic hooks #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
added
local-state-query
Issues / PRs related to local-state-query protocol
networking
node-to-client
Issues & PRs related to node-to-client protocols
labels
Jan 22, 2021
A typical client would here want to be able to run extra computation in order to carry on and do whatever it needs to do to collect or constuct the next request to send. Being restricted to only pure computation here makes it fairly hard to pipelined another request unless the request can be constructed out of thin air or, has already been collected and buffered upfront.
coot
force-pushed
the
coot/recvMsgAcquired
branch
from
January 25, 2021 08:23
191fd25
to
65a79aa
Compare
coot
changed the title
LocalStQuery client: allow monadic action in recvMsgAcquired
LocalStQuery and ChainSync clients: aditional monadic hooks
Jan 25, 2021
karknu
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
bors merge |
Build succeeded: |
dcoutts
reviewed
Feb 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
newhoggy
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Feb 10, 2021
newhoggy
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Feb 10, 2021
newhoggy
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Feb 10, 2021
iohk-bors bot
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Feb 10, 2021
2345: Update cardano-ledger-specs r=newhoggy a=newhoggy * Pushed the `cardano-ledger-specs` and `ouroboros-network` dependencies as far forward as I can without compile errors * Code changes for IntersectMBO/ouroboros-network#2896 Co-authored-by: John Ky <john.ky@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chain-sync
local-state-query
Issues / PRs related to local-state-query protocol
node-to-client
Issues & PRs related to node-to-client protocols
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2895 and incorporates #2011.