Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalStQuery and ChainSync clients: aditional monadic hooks #2896

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

coot
Copy link
Contributor

@coot coot commented Jan 22, 2021

Fixes #2895 and incorporates #2011.

@coot coot requested a review from dcoutts January 22, 2021 16:21
@coot coot added local-state-query Issues / PRs related to local-state-query protocol networking node-to-client Issues & PRs related to node-to-client protocols labels Jan 22, 2021
coot and others added 2 commits January 25, 2021 09:23
A typical client would here want to be able to run extra computation in
order to carry on and do whatever it needs to do to collect or constuct
the next request to send.  Being restricted to only pure computation
here makes it fairly hard to pipelined another request unless the
request can be constructed out of thin air or, has already been
collected and buffered upfront.
@coot coot changed the title LocalStQuery client: allow monadic action in recvMsgAcquired LocalStQuery and ChainSync clients: aditional monadic hooks Jan 25, 2021
@coot coot requested a review from karknu February 1, 2021 09:18
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coot
Copy link
Contributor Author

coot commented Feb 2, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 2, 2021

@iohk-bors iohk-bors bot merged commit 336718a into master Feb 2, 2021
@iohk-bors iohk-bors bot deleted the coot/recvMsgAcquired branch February 2, 2021 12:50
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

newhoggy added a commit to IntersectMBO/cardano-node that referenced this pull request Feb 10, 2021
newhoggy added a commit to IntersectMBO/cardano-node that referenced this pull request Feb 10, 2021
newhoggy added a commit to IntersectMBO/cardano-node that referenced this pull request Feb 10, 2021
iohk-bors bot added a commit to IntersectMBO/cardano-node that referenced this pull request Feb 10, 2021
2345: Update cardano-ledger-specs r=newhoggy a=newhoggy

* Pushed the `cardano-ledger-specs` and `ouroboros-network` dependencies as far forward as I can without compile errors
* Code changes for IntersectMBO/ouroboros-network#2896


Co-authored-by: John Ky <john.ky@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chain-sync local-state-query Issues / PRs related to local-state-query protocol node-to-client Issues & PRs related to node-to-client protocols
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Allow Local State Client to idle in the acquired state
4 participants