Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Req/Rep protocol documentation #3217

Merged
merged 1 commit into from Jun 16, 2021
Merged

Fixed Req/Rep protocol documentation #3217

merged 1 commit into from Jun 16, 2021

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Jun 15, 2021

Tackles #3201

@bolt12
Copy link
Contributor Author

bolt12 commented Jun 15, 2021

image

@bolt12 bolt12 linked an issue Jun 15, 2021 that may be closed by this pull request
network-spec: Inconsistent documentation and code #3201
Closed
coot
coot approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bolt12
Copy link
Contributor Author

bolt12 commented Jun 16, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 16, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit be47fbb into master Jun 16, 2021
@iohk-bors iohk-bors bot deleted the bolt12/master-3201-docs branch June 16, 2021 08:12
coot pushed a commit that referenced this pull request May 16, 2022
@iohk-bors @bolt12
Merge #3217
638624e 
3217: Fixed Req/Rep protocol documentation r=bolt12 a=bolt12

Tackles #3201 

Co-authored-by: Armando Santos <armando@well-typed.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@karknu karknu Awaiting requested review from karknu

@njd42 njd42 Awaiting requested review from njd42 njd42 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

network-spec: Inconsistent documentation and code
2 participants
@bolt12 @coot