Stop mux incase termination of miniprotocols timeout #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
requested changes
Jan 17, 2022
ouroboros-network/src/Ouroboros/Network/PeerSelection/PeerStateActions.hs
Outdated
Show resolved
Hide resolved
When demoting a peer to cold there is a 300s timeout for the miniprotocols to terminate. In case of timeout the connection will be left hanging, it will only be unregistered. The next time the peer is promoted to warm there may still be lingering miniprotocols in an unknown state. By calling stopMux we ensure that the connection will be reset.
unregisterOutboundConnection isn't needed after stopMux.
If keepalive or blockfetch's unregister function is interrupted it will cause some state to be left. This will result in a space leak and an assertion failure the next time the node attempt to talk to that peer. Change their unregister functions to run inside uninterruptibleMask_.
karknu
force-pushed
the
karknu/peerstateaction_timeout
branch
from
a3aa9bf
to
51fb6f4
Compare
|
bors merge |
|
Build succeeded: |
|
Fixes #3570 |
karknu
added a commit
that referenced
this pull request
Jan 21, 2022
3575: Stop mux incase termination of miniprotocols timeout r=coot a=karknu When demoting a peer to cold there is a 300s timeout for the miniprotocols to terminate. In case of timeout the connection will be left hanging, it will only be unregistered. The next time the peer is promoted to warm there may still be lingering miniprotocols in an unknown state. By calling stopMux we ensure that the connection will be reset. Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When demoting a peer to cold there is a 300s timeout for the
miniprotocols to terminate. In case of timeout the connection will be
left hanging, it will only be unregistered. The next time the
peer is promoted to warm there may still be lingering miniprotocols in
an unknown state.
By calling stopMux we ensure that the connection will be
reset.