Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace exceptions thrown by inboundGovernorLoop #3591

Merged
merged 1 commit into from Feb 2, 2022
Merged

Trace exceptions thrown by inboundGovernorLoop #3591

merged 1 commit into from Feb 2, 2022

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Jan 27, 2022 •
edited

This PR adds exception tracing for InboundGovernorLoop.

This improves the tracing thouroughness of the system.

@bolt12 bolt12 linked an issue Jan 27, 2022 that may be closed by this pull request
Trace exceptions thrown by inboundGovernorLoop #3470
Closed
@bolt12 bolt12 added inbound-governor Issues / PRs related to inbound-governor networking labels Jan 27, 2022
@bolt12 bolt12 force-pushed the bolt12/trace-inboundGovernor-exceptions branch from 22a202c to 1cb84c3 Compare January 28, 2022 10:07
@bolt12 bolt12 force-pushed the bolt12/trace-inboundGovernor-exceptions branch from 1cb84c3 to 0ca6cda Compare January 28, 2022 10:20
coot
coot approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please also open a PR in cardano-node or contribute to one that's already opened by the another team (e.g. consensus).

@bolt12
Copy link
Contributor Author

bolt12 commented Feb 2, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 2, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 9a19754 into master Feb 2, 2022
@iohk-bors iohk-bors bot deleted the bolt12/trace-inboundGovernor-exceptions branch February 2, 2022 11:47
coot pushed a commit that referenced this pull request May 16, 2022
@iohk-bors @bolt12
Merge #3591
5ef6d18 
3591: Trace exceptions thrown by inboundGovernorLoop r=bolt12 a=bolt12



Co-authored-by: Armando Santos <armando@well-typed.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@karknu karknu Awaiting requested review from karknu

Assignees

@bolt12 bolt12

Labels
inbound-governor Issues / PRs related to inbound-governor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trace exceptions thrown by inboundGovernorLoop
2 participants
@bolt12 @coot