Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffusion test for inbound governor transitions #3633

Merged
merged 8 commits into from Apr 26, 2022

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Feb 23, 2022

No description provided.

@bolt12 bolt12 added inbound-governor Issues / PRs related to inbound-governor networking labels Feb 23, 2022
@bolt12 bolt12 linked an issue Feb 23, 2022 that may be closed by this pull request
2 tasks
@bolt12 bolt12 added this to in progress in Connection Manager via automation Feb 23, 2022
@bolt12 bolt12 changed the base branch from master to bolt12/diffusion-test-cm-transitions February 24, 2022 15:02
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-cm-transitions branch from 545fa42 to f84ef47 Compare February 25, 2022 15:09
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-ig-transitions branch 3 times, most recently from 1acabe6 to 4fcfd12 Compare February 25, 2022 16:36
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-cm-transitions branch from f84ef47 to b6bd1de Compare February 25, 2022 16:36
@bolt12 bolt12 added the diffusion Issues / PRs related to diffusion layer label Feb 25, 2022
@coot coot changed the title Diffusion test ig transitions Diffusion test for inbound governor transitions Feb 28, 2022
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-cm-transitions branch from b6bd1de to 719292a Compare March 1, 2022 15:02
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-ig-transitions branch from 4fcfd12 to 108e446 Compare March 1, 2022 15:03
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-cm-transitions branch 3 times, most recently from 23c0eeb to 5ea48ea Compare March 15, 2022 12:36
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-cm-transitions branch from 5ea48ea to 2f5af98 Compare April 11, 2022 10:00
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-ig-transitions branch from 108e446 to 2ed7e98 Compare April 11, 2022 10:04
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-cm-transitions branch from 2f5af98 to 61133c1 Compare April 13, 2022 14:15
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-ig-transitions branch from 2ed7e98 to 11462ec Compare April 13, 2022 16:15
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-cm-transitions branch from 61133c1 to 16d805c Compare April 14, 2022 09:16
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-ig-transitions branch from 11462ec to 45c624f Compare April 14, 2022 09:22
@bolt12 bolt12 removed the request for review from karknu April 19, 2022 11:28

-- | Specification of the transition table of the inbound governor.
--
verifyRemoteTransition :: RemoteTransition -> Bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in review of #3629, this function should be imported from a testing library in ouroboros-network-framework.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

-- Assuming all transitions in the transition list are valid, we only need to
-- look at the 'toState' of the current transition and the 'fromState' of the
-- next transition.
verifyRemoteTransitionOrder :: [RemoteTransition]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@bolt12 bolt12 force-pushed the bolt12/diffusion-test-cm-transitions branch 2 times, most recently from 67ab868 to 7820864 Compare April 20, 2022 10:03
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bolt12 bolt12 force-pushed the bolt12/diffusion-test-cm-transitions branch from e424db2 to 2406460 Compare April 22, 2022 14:16
@bolt12 bolt12 force-pushed the bolt12/diffusion-test-ig-transitions branch from a7f077c to 45371bd Compare April 22, 2022 14:21
@bolt12 bolt12 changed the base branch from bolt12/diffusion-test-cm-transitions to master April 25, 2022 08:34
@bolt12
Copy link
Contributor Author

bolt12 commented Apr 25, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Apr 25, 2022
3633: Diffusion test for inbound governor transitions r=bolt12 a=bolt12



Co-authored-by: Armando Santos <armando@well-typed.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 25, 2022

Build failed:

@bolt12
Copy link
Contributor Author

bolt12 commented Apr 26, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Apr 26, 2022
3633: Diffusion test for inbound governor transitions r=bolt12 a=bolt12



Co-authored-by: Armando Santos <armando@well-typed.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 26, 2022

Build failed:

@bolt12
Copy link
Contributor Author

bolt12 commented Apr 26, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Apr 26, 2022
3633: Diffusion test for inbound governor transitions r=bolt12 a=bolt12



Co-authored-by: Armando Santos <armando@well-typed.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 26, 2022

Timed out.

@bolt12
Copy link
Contributor Author

bolt12 commented Apr 26, 2022

bors retry

iohk-bors bot added a commit that referenced this pull request Apr 26, 2022
3633: Diffusion test for inbound governor transitions r=bolt12 a=bolt12



Co-authored-by: Armando Santos <armando@well-typed.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 26, 2022

Timed out.

@bolt12
Copy link
Contributor Author

bolt12 commented Apr 26, 2022

bors retry

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 26, 2022

@iohk-bors iohk-bors bot merged commit 6d11459 into master Apr 26, 2022
Connection Manager automation moved this from in progress to done Apr 26, 2022
@iohk-bors iohk-bors bot deleted the bolt12/diffusion-test-ig-transitions branch April 26, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diffusion Issues / PRs related to diffusion layer inbound-governor Issues / PRs related to inbound-governor
Projects
Development

Successfully merging this pull request may close these issues.

Diffusion test of Inbound-Gov valid transitions
2 participants