Don't overwrite localrootpeers lookup results #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of updating the rootPeersGroupsVar every thread monitoring a domain had their own cached copy of rootPeersGroups which it applied changes to. This meant that only one thread's results where used, causing the other localrootpeers to go away. However the missing localrootpeers would still be known peers, which meant that they could still be randomly promoted.
|
Fixes #3524 |
coot
approved these changes
Feb 28, 2022
|
bors r+ |
|
Build succeeded: |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 16, 2022
3643: RootPeersDNS: garbage collect DNS results && test single source of truth r=bolt12 a=bolt12 This PR extends the existing test suite for RootPeersDNS by making the MockRoots more robust, and adding a test to check if localRootPeersProvider has a single source of truth. It also fixes #3650. This was motivated by a bug found by `@karknu` and fixed in #3641 . Co-authored-by: Armando Santos <armandoifsantos@gmail.com>
iohk-bors bot
added a commit
that referenced
this pull request
Mar 16, 2022
3643: RootPeersDNS: garbage collect DNS results && test single source of truth r=bolt12 a=bolt12 This PR extends the existing test suite for RootPeersDNS by making the MockRoots more robust, and adding a test to check if localRootPeersProvider has a single source of truth. It also fixes #3650. This was motivated by a bug found by `@karknu` and fixed in #3641 . Co-authored-by: Armando Santos <armandoifsantos@gmail.com>
coot
pushed a commit
that referenced
this pull request
May 16, 2022
3643: RootPeersDNS: garbage collect DNS results && test single source of truth r=bolt12 a=bolt12 This PR extends the existing test suite for RootPeersDNS by making the MockRoots more robust, and adding a test to check if localRootPeersProvider has a single source of truth. It also fixes #3650. This was motivated by a bug found by `@karknu` and fixed in #3641 . Co-authored-by: Armando Santos <armandoifsantos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of updating the rootPeersGroupsVar every thread monitoring a
domain had their own cached copy of rootPeersGroups which it applied
changes to. This meant that only one thread's results where used,
causing the other localrootpeers to go away. However the missing
localrootpeers would still be known peers, which meant that they could
still be randomly promoted.