Removed ST effects from IOSimPOR #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6b986f1.
ST computations can not be shared by multiple threads, they are always thread local; which means they never can race with anything else. This means we don't need to track ST effects, and consider them when checking if two steps race or not.
|
This looks good to me. |
bolt12
approved these changes
Mar 14, 2022
|
bors merge |
|
Build succeeded: |
coot
added a commit
that referenced
this pull request
May 16, 2022
3640: Connection manager transition order test using IOSimPOR r=coot a=coot This PR adds a quickcheck property test which validates order of connection manager transitions using *IOSimPOR*. It also fixes a connection manager bug discovered thanks to the new test. Fixes #3613. - connection-manager-tests: test transition order - connection-manager: don't blindly override state - connection-manager-tests: code style 3662: Removed ST effects from IOSimPOR r=coot a=coot ST effects are thread local, they never race with other steps. This patch reverts a previous fix commited in PR #3647. Thanks for `IOSimPOR` we also found out that the transition: `UnnegotiatedSt Inbound → TerminatingSt` should be valid, similarly to one for outbound connections (see PR #3652, commit fbcb6aa). Co-authored-by: Marcin Szamotulski <coot@coot.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ST effects are thread local, they never race with other steps. This patch
reverts a previous fix commited in PR #3647.
Thanks for
IOSimPORwe also found out that the transition:UnnegotiatedSt Inbound → TerminatingStshould be valid, similarly to one foroutbound connections (see PR #3652, commit fbcb6aa).