Enabled accept errors in net-sim testing #3668
Merged
+125
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/test-accept-errors
branch
2 times, most recently
from
db16632
to
5528e75
Compare
`toBearerInfo` should be defined in the same module as 'AbsBearerInfo'.
`IOErrThrowOrReturn` was used to instruct the `accept` call to either throw or return an exception. However, the implementation of a snocket's `accept` has to guarantee that the lower level `accept` call (e.g. OS) has proper exception handling which guarantees that all thrown exceptions are caught. For this reason we should not instruct the `net-sim` implementation to leak exceptions and throw them but always return them.
The simulation needs to reset the channel if an exception is returned by the accept call or we will leak a socket.
This allows us to include 'biAcceptFailure' field of 'BearerInfo'.
The property should not fail when it's expected to fail, e.g. when 'abiAcceptFailure' is provided, 'accept' call is expected to throw an exception.
`cmTracer` and `inboundTracer` were mismatched.
`mkConnection` returns a pair of channels: local -> remote and remote -> local. The second one had misconfigured connection id, resulting in confusing log messages.
coot
force-pushed
the
coot/test-accept-errors
branch
from
5528e75
to
76aee01
Compare
|
bors merge |
|
Build succeeded: |
coot
added a commit
that referenced
this pull request
May 16, 2022
3668: Enabled accept errors in net-sim testing r=coot a=coot Fixes #3315 - ouroboros-network-framework: added todo - sim-net: removed IOErrThrowOrReturn as an abstraction leak - sim-net: reset channel when accept errors - net-sim: added abiAcceptFailure - net-sim: refactor TestError - net-sim: fix prop_connect_to_accepting_socket - Fixed some typos Co-authored-by: Marcin Szamotulski <coot@coot.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3315