Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed how DNS Lookup for local root peers works #4571

Merged
merged 3 commits into from
May 26, 2023
Merged

Changed how DNS Lookup for local root peers works #4571

merged 3 commits into from
May 26, 2023

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented May 25, 2023

Description

Part one of fix for #4563 . This fixes the way we store DNS lookup results.

@bolt12 bolt12 requested a review from coot as a code owner May 25, 2023 15:10
@bolt12 bolt12 changed the title Changed the DNS Lookup for local root peers works Changed how DNS Lookup for local root peers works May 25, 2023
@bolt12 bolt12 force-pushed the bolt12/fix-dns branch 2 times, most recently from bc00d25 to 3f82a61 Compare May 25, 2023 15:55
coot
coot approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot linked an issue May 25, 2023 that may be closed by this pull request
ActivePeers on Node 8.0.0 (P2P-Mode) getting lower over time #4563
Closed
coot added a commit to IntersectMBO/cardano-node that referenced this pull request May 26, 2023
@coot
Include #4751 to test over cardano-node-8.0.0
c9fa69e 
IntersectMBO/ouroboros-network#4571
@coot coot mentioned this pull request May 26, 2023
Open
9 tasks
@coot
Copy link
Contributor

coot commented May 26, 2023 •
edited

Please include CHANGELOG entry, not that that your change will require a major bump of ouroboros-network.

@bolt12 bolt12 enabled auto-merge May 26, 2023 08:46
@bolt12 bolt12 added this pull request to the merge queue May 26, 2023
Merged via the queue into master with commit e688af9 May 26, 2023
8 checks passed
@bolt12 bolt12 deleted the bolt12/fix-dns branch May 26, 2023 10:06
@coot coot added the networking label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ActivePeers on Node 8.0.0 (P2P-Mode) getting lower over time
2 participants
@bolt12 @coot