Initialise local root peers result #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug where results `TVar` was never initialised if all local root peers were provided with their IP addresses, and thus the node didn't try to connect to any of its local root peers. We add `LocalRootPeersResult` to `TestTraceEvent` which is used to track values committed to the `TVar` which holds local root peers with resolved dns names. It is more robust to use `traceTVarIO` than to relay on `TraceLocalRootPeers` events, as we can force the latter to be traced even if there's no dns name to be resolved. This captures the case where local root peers contains only IP addresses.
Merged
bolt12
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where results
TVarwas never initialised if alllocal root peers were provided with their IP addresses, and thus the
node didn't try to connect to any of its local root peers.
We add
LocalRootPeersResulttoTestTraceEventwhich is used to trackvalues committed to the
TVarwhich holds local root peers withresolved dns names. It is more robust to use
traceTVarIOthan torelay on
TraceLocalRootPeersevents, as we can force the latter to betraced even if there's no dns name to be resolved. This captures the
case where local root peers contains only IP addresses.