Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NotReleasedConnections in Server2 tests #4623

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix NotReleasedConnections in Server2 tests #4623

merged 1 commit into from
Oct 27, 2023
+17 −15

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Jul 12, 2023

Fix #4607

@bolt12 bolt12 requested a review from coot as a code owner July 12, 2023 11:29
@bolt12 bolt12 force-pushed the bolt12/4607 branch 2 times, most recently from 31db120 to 5e6d2ba Compare July 12, 2023 15:08
@bolt12
Copy link
Contributor Author

bolt12 commented Jul 13, 2023

This also fixes #4605

@bolt12 bolt12 linked an issue Jul 13, 2023 that may be closed by this pull request
not released connection in simulation #4605
Closed
coot
coot reviewed Aug 23, 2023
View reviewed changes
ouroboros-network-framework/CHANGELOG.md Outdated Show resolved Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs Outdated Show resolved Hide resolved
ouroboros-network-framework/CHANGELOG.md Outdated Show resolved Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs Outdated Show resolved Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs Outdated Show resolved Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs Outdated Show resolved Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs Outdated Show resolved Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs Outdated Show resolved Hide resolved
@bolt12 bolt12 force-pushed the bolt12/4607 branch 2 times, most recently from 5fe5bbf to a446e78 Compare September 1, 2023 14:40
@bolt12 bolt12 requested a review from coot September 4, 2023 08:35
@bolt12 bolt12 requested a review from coot September 26, 2023 11:51
@bolt12 bolt12 changed the title Fix MultiNodeScript generator Fix NotReleasedConnections in Server2 tests Sep 29, 2023
coot
coot approved these changes Oct 4, 2023
View reviewed changes
ouroboros-network-framework/CHANGELOG.md Outdated Show resolved Hide resolved
@bolt12 bolt12 requested a review from coot October 6, 2023 10:04
coot
coot approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot mentioned this pull request Oct 10, 2023
Merged
@bolt12 bolt12 added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
@bolt12 bolt12 added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
@bolt12 bolt12 added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
@bolt12 bolt12 added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
@bolt12 bolt12 added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
@bolt12 bolt12 added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
@bolt12 bolt12 added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
@bolt12 bolt12 added this pull request to the merge queue Oct 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 12, 2023
@bolt12 bolt12 added this pull request to the merge queue Oct 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 12, 2023
@bolt12 bolt12 added this pull request to the merge queue Oct 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2023
@bolt12 bolt12 added this pull request to the merge queue Oct 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2023
@bolt12 bolt12 mentioned this pull request Oct 23, 2023
Closed
@bolt12 bolt12 linked an issue Oct 23, 2023 that may be closed by this pull request
InboundGovernor leaks a connection in a test #4694
Closed
@bolt12 bolt12 mentioned this pull request Oct 27, 2023
Closed
9 tasks
@bolt12 bolt12 enabled auto-merge October 27, 2023 10:52
@bolt12 bolt12 added this pull request to the merge queue Oct 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 27, 2023
@coot coot added this pull request to the merge queue Oct 27, 2023
Merged via the queue into master with commit 551dc22 Oct 27, 2023
11 checks passed
@coot coot deleted the bolt12/4607 branch October 27, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees

@bolt12 bolt12

Labels
testing
Projects
None yet
Milestone
No milestone
2 participants
@bolt12 @coot