-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix.flake: simplify nix setup #4640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/flake.nix
branch
11 times, most recently
from
August 14, 2023 08:56
3c6bb27
to
42f91c9
Compare
coot
force-pushed
the
coot/flake.nix
branch
5 times, most recently
from
August 14, 2023 10:39
5ea18aa
to
1483dfd
Compare
bolt12
approved these changes
Aug 14, 2023
coot
added
nix
This includes CI, nix changes or cabal dependencies
CI
Issues / PRs related to CI
labels
Aug 14, 2023
disassembler
approved these changes
Aug 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 14, 2023
|
coot
force-pushed
the
coot/flake.nix
branch
2 times, most recently
from
August 15, 2023 05:03
6feb796
to
e516500
Compare
Based on `cardano-cli` `nix.flake`.
This patch also disables testing when cross compiling with Nix.
GHC-9.6.2 is only used on Linux.
We use `GHC-9.6.2` on Hydra.
With GHC-9.6.2 there's a cross compilation error: https://ci.iog.io/build/623082/nixlog/2
This solves the problem of providing shell with a HLS. The drawback is that we now build with both `8.10.7` and `9.6.2` on all three platforms: `x86_64-linux`, `x86_64-darwin`, `aarch64-darwin`. Previously we only used `9.6.2` on `x86_64-linux`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides
nix.flake
which builds onx86_64-linux
,x86_64-darwin
, andaarch64-darwin
on
x86_64-linux
it cross compoiles to Windows. All project settings are set in `./scripts/ci/cabal.project.local.{Windows,Windows.CrossCompile,Linux}. They are also used for GitHub actions, and that's the preferred way to change configuration option.The tests & benchmarks are disabled in the
cabal.project.local.Windows.CrossCompile
.The
cabal.project.local.Linux
is used on all the above platforms;cabal.project.local.Windows
is only used on GitHub actions.Nix is using two compilers:
ghc-8.10.7
andghc-9.6.2
GitHub Actions, only build with
ghc-8.10.7
onwindows-latest
.There is a shell available with
nix develop
which gives access toghc-9.6.2
and some other build tools.Based on
cardano-cli
nix.flake
.