Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Idle timeouts #4648

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Add Idle timeouts #4648

merged 3 commits into from
Aug 22, 2023
+4 −2

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Aug 18, 2023 •
edited

Description

Add timeouts to chainsync's TokIdle state and keepalive's TokClient state.

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@karknu
Add idle timeout for chainsync
6a6f131 
Add idle timeout for chainsync in order to detect and remove stale
connections.
@karknu
Add a 97s timeout on the server side.
899fbef 
The added timeout means that servers will require their client to be
somewhat active. This means that stale connections will be detected and
thorn down.
@karknu karknu requested a review from coot as a code owner August 18, 2023 13:32
coot
coot reviewed Aug 21, 2023
View reviewed changes
ouroboros-network-protocols/CHANGELOG.md Outdated Show resolved Hide resolved
ouroboros-network-protocols/CHANGELOG.md Outdated Show resolved Hide resolved
coot
coot approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot added this pull request to the merge queue Aug 22, 2023
@coot coot removed this pull request from the merge queue due to a manual request Aug 22, 2023
@coot coot added this pull request to the merge queue Aug 22, 2023
Merged via the queue into IntersectMBO:master with commit 408d1c5 Aug 22, 2023
8 checks passed
@karknu karknu deleted the karknu/idle_timeout_m branch August 24, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees

@karknu karknu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karknu @coot