Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some micro- benchmarks for PeerMetrics #4663

Merged
merged 11 commits into from
Oct 27, 2023
Merged

Add some micro- benchmarks for PeerMetrics #4663

merged 11 commits into from
Oct 27, 2023

Conversation

mtullsen
Copy link
Contributor

Description

This resolves #3832.

The goals of this PR are to

  • Create one time/space benchmark (as a paradigm for other benchmarks to follow).
  • Adapt the the PeerMetric testing code into an efficient benchmark that we can use for both time & space measurements of the PeerMetric code.

One can run the benchmark thus

cabal bench sim-benchmarks
cabal bench --benchmark-options '+RTS -T' sim-benchmarks
  # this adds space profiling

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@mtullsen mtullsen requested a review from coot as a code owner August 31, 2023 19:19
coot
coot approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtullsen mtullsen force-pushed the galois/issue-3832-add-microbenchmark branch from 17cbc34 to c9979ee Compare September 17, 2023 07:36
@coot coot enabled auto-merge September 25, 2023 14:27
@coot
Copy link
Contributor

coot commented Sep 25, 2023

There's a build failure: https://github.com/input-output-hk/ouroboros-network/actions/runs/6212332000/job/17104416622; It seems wrong version of tasty is required. I added emptyProgress to tasty-1.5.

auto-merge was automatically disabled September 30, 2023 06:28

Head branch was pushed to by a user without write access

@mtullsen mtullsen force-pushed the galois/issue-3832-add-microbenchmark branch from c9979ee to 1b3420c Compare September 30, 2023 06:28
@mtullsen mtullsen force-pushed the galois/issue-3832-add-microbenchmark branch from 1b3420c to f1cc348 Compare October 4, 2023 01:18
@mtullsen mtullsen requested a review from a team as a code owner October 4, 2023 15:53
@mtullsen
Copy link
Contributor Author

@coot : with the last commit, c7bb570 , the only failures I'm seeing are timeouts and various "un-understandable to me" nix failures. Any guidance here? Thanks.

mtullsen and others added 9 commits October 27, 2023 11:09
@mtullsen @coot
refactor ouroboros-network.cabal: add sim-tests-lib and a 'common' st…
92fa987 
…anza
@mtullsen @coot
PeerMetric.hs refactors: explicit imports, unneeded type constraints,…
8ecd57b 
… misc
@mtullsen @coot
add benchmark 'sim-benchmarks' to ouroboros-network
d35cdb1 
- new bench/Main.hs
- new cabal target
- extending ouroboros-network/sim-tests/**/PeerMetric.hs
@mtullsen @coot
ouroboros-network.cabal refactor & remove-warning
1a75238 
- separate library and executable stanzas
@mtullsen @coot
ouroboros-network.cabal refactor: sort module names
e334abd
@mtullsen @coot
fix package builds with latest hackage and latest tasty-bench pkg.
e43d0f2
@disassembler @coot
update hackage
0ae9dce 
* also exposes project at top-level for debugging
@coot
flake: updated hackageNix & haskellNix
5c001e9
@coot
ouroboros-network: renamed directories
905babf 
* `sim-tests-lib` in `sim-test-lib` subdirectory
* `sim-test` in `sim-test` subdirectory
@coot coot force-pushed the galois/issue-3832-add-microbenchmark branch from 8469818 to 693d2b3 Compare October 27, 2023 10:15
@coot
Copy link
Contributor

coot commented Oct 27, 2023

@mtullsen I rebased the PR, and added a few benign commits on top.

@coot coot force-pushed the galois/issue-3832-add-microbenchmark branch from 693d2b3 to 864f085 Compare October 27, 2023 10:19
@coot
ouroboros-network: refactored cabal file
9cb9afa 
* Added standard GHC flags, including `-Wunused-packages`. I only
  omitted `-Wredundant-constraints` which requires a lot of code
  changes.
* Removed `sim-test-common` stantza as it was pulling a lot of
  dependencies where they are not needed.
@coot
ouroboros-network: code style
7d0ccbe
@coot coot force-pushed the galois/issue-3832-add-microbenchmark branch from 864f085 to 7d0ccbe Compare October 27, 2023 10:56
@coot coot enabled auto-merge October 27, 2023 11:20
@coot coot added this pull request to the merge queue Oct 27, 2023
Merged via the queue into IntersectMBO:master with commit d678828 Oct 27, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

@coot coot coot approved these changes

@bolt12 bolt12 Awaiting requested review from bolt12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate space and execution time measurments in some of the tests
3 participants
@mtullsen @coot @disassembler