Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-5775: plutus-ledger refactoring #1091

Merged
merged 4 commits into from Jun 28, 2023
Merged

PLT-5775: plutus-ledger refactoring #1091

merged 4 commits into from Jun 28, 2023

Conversation

sjoerdvisscher
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher commented Jun 22, 2023 •
edited

So there's no reduction in dependencies at all. I got rid of the direct plutus-script-utils dependency from cardano-node-emulator, but it is still an indirect dependency through plutus-ledger. Maybe if we can get rid of DecoratedTxOut in the future we could remove the dependency completely.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
    • Important changes are reflected in changelog.d of the affected packages
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reference the ADR in the PR and reference the PR in the ADR (if revelant)
    • Reviewer requested

@sjoerdvisscher sjoerdvisscher changed the title Plt 5775 node emulaotr less dependencies PLT-5775: node emulator refactoring Jun 23, 2023
@sjoerdvisscher sjoerdvisscher changed the title PLT-5775: node emulator refactoring PLT-5775: plutus-ledger refactoring Jun 23, 2023
@berewt
Copy link
Contributor

berewt commented Jun 27, 2023

All the improvements look good to me but we're far from the story goal (that seems impossible to achieve). I think we can merge this one and we'll decide later on what to do with plutus-ledger. @koslambrou does it sound ok for you?

@koslambrou
Copy link
Contributor

Fine by me

berewt
berewt approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@berewt berewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it then!

@sjoerdvisscher
Copy link
Contributor Author

@koslambrou Can you force merge?

@koslambrou koslambrou merged commit 8103138 into main Jun 28, 2023
4 of 5 checks passed
@koslambrou koslambrou deleted the PLT-5775-node-emulaotr-less-dependencies branch June 28, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berewt berewt berewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjoerdvisscher @berewt @koslambrou