Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContractResponse: enforce PABResp with PABReq #3672

Merged
merged 1 commit into from Aug 4, 2021
Merged

ContractResponse: enforce PABResp with PABReq #3672

merged 1 commit into from Aug 4, 2021

Conversation

luigy
Copy link
Contributor

@luigy luigy commented Aug 2, 2021 •
edited

in order to minimize mismatches similar to the one on 83a1f39 #3628

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@luigy luigy requested a review from j-mueller August 2, 2021 19:02
@luigy luigy force-pushed the ll/ContractResponse-PABResp-PABReq branch from 9085326 to 62f8de7 Compare August 2, 2021 19:06
@luigy luigy changed the title ContractResponse: enforce PABResq with PABReq ContractResponse: enforce PABResp with PABReq Aug 2, 2021
j-mueller
j-mueller approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@j-mueller j-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@luigy
Copy link
Contributor Author

luigy commented Aug 3, 2021

@michaelpj looks like hydra failed to update the status

@michaelpj
Copy link
Contributor

True, but it also has conflicts.

@silky
Copy link
Contributor

silky commented Aug 3, 2021

@michaelpj That's my fault; I snuck in a merge between @luigy 's comment and yours :D

@luigy
Copy link
Contributor Author

luigy commented Aug 3, 2021

Oh looks like that just happened after my comment. I'll update which will hopefully get hydra through

@luigy luigy force-pushed the ll/ContractResponse-PABResp-PABReq branch from 62f8de7 to 60b6d57 Compare August 3, 2021 15:03
@luigy luigy force-pushed the ll/ContractResponse-PABResp-PABReq branch from 60b6d57 to 9422300 Compare August 4, 2021 16:10
@luigy luigy merged commit 39aa6d1 into master Aug 4, 2021
@luigy luigy deleted the ll/ContractResponse-PABResp-PABReq branch August 4, 2021 17:52
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2021
Open
This was referenced Sep 13, 2021
Open
Open
@rmourey26 rmourey26 mentioned this pull request May 13, 2022
Open
@rmourey26 rmourey26 mentioned this pull request Jun 21, 2023
Open
@rmourey26 rmourey26 mentioned this pull request Dec 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-mueller j-mueller j-mueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luigy @michaelpj @silky @j-mueller