Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build plutus-playground-client on Hydra #398

Merged
merged 2 commits into from Dec 7, 2018

Conversation

michaelpj
Copy link
Contributor

We're not building it or running the tests, which is bad.

I think this adds it to release.nix, but in the process I discovered it doesn't build. Probably sandboxing issues.

I've fixed one (missing python2 dep), but now I'm getting networking errors.

@michaelpj
Copy link
Contributor Author

If you work out what it is, feel free to push to this branch. Hydra's going to take a while since this is the first time it's built any of the dependencies.

@michaelpj
Copy link
Contributor Author

Okay, it indeed fails in a similar way.

@shmish111
Copy link
Contributor

Kris [1:23 PM]
It’s because we’re using a special nixpkgs, but that’s not defined in the jobset, so it won’t be prefetched. So it can’t be reached from inside the sandbox.

We have to see if we can build without that extra nixpkgs fork, and if not, get it fed through from the jobset.

@shmish111
Copy link
Contributor

it doesn't build without that fork

@michaelpj
Copy link
Contributor Author

That's not the issue, the extra nixpkgs is just fine. It gets way past that.

@michaelpj
Copy link
Contributor Author

fetchtarball is fine in sandboxing otherwise literally nothing would work ;)

@michaelpj
Copy link
Contributor Author

It's some node-gyp thing.

@shmish111
Copy link
Contributor

yeah it's trying to build nodejs, something deep inside, not one of our derivations

@michaelpj
Copy link
Contributor Author

No, it's during the build of plutus-playground-client. I don't know why that's calling node-gyp to do something but it is.

@shmish111
Copy link
Contributor

gyp http GET https://nodejs.org/download/release/v6.12.2/node-v6.12.2-headers.tar.gz is what fails

@michaelpj
Copy link
Contributor Author

Maybe your yarn.nix is out of date so it's trying to build some of the missing packages?

@shmish111
Copy link
Contributor

no, seems to be up to date, it would probably fail to build in non-sanboxed if that were the case

@michaelpj
Copy link
Contributor Author

It's happening during yarn install, for some reason node-sass is doing stuff. It is included in yarn.nix, so I'd have thought it shouldn't be doing stuff...

@michaelpj
Copy link
Contributor Author

@michaelpj
Copy link
Contributor Author

Can't see how to get the binary binding that it wants from anywhere. Going to leave this in your court...

@michaelpj
Copy link
Contributor Author

fetchurl-ing the binaries from their releases page seems to work.

@shmish111 shmish111 merged commit 6fb21fa into master Dec 7, 2018
@kwxm kwxm deleted the fix/playground-client-hydra branch April 30, 2019 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants