Benchmark the production code fully rather than some arbitrary thing #5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/benchmark validation-full |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of ' validation-full' on '7f3fabd2d1' (base) and '3430c60cf4' (PR) Results table
|
effectfully
force-pushed
the
effectfully/benchmarking/stop-the-irrelevance-in-full
branch
from
3430c60
to
dfdc6b5
Compare
|
^ yay, noise. |
bezirg
approved these changes
Jun 29, 2023
bezirg
reviewed
Jun 29, 2023
| -- strictify and "short" the result cbor to create a real `SerialisedScript` | ||
| !benchScript = force . serialiseUPLC $ UPLC.Program () ver term | ||
| eval script = do | ||
| either (error . show) (\_ -> ()) . snd $ evaluateScriptRestricting |
There was a problem hiding this comment.
You can use i think const () . PlutusPrelude.unsafeFromRight
There was a problem hiding this comment.
I think that'd return () regardless of whether we get Left or Right and we do want to throw on Left instead.
bezirg
reviewed
Jun 29, 2023
| (term, args) = peelDataArguments body | ||
| -- strictify and "short" the result cbor to create a real `SerialisedScript` | ||
| !benchScript = force . serialiseUPLC $ UPLC.Program () ver term | ||
| eval script = do |
There was a problem hiding this comment.
Yup, thanks, fixed.
effectfully
force-pushed
the
effectfully/benchmarking/stop-the-irrelevance-in-full
branch
from
dfdc6b5
to
e84de84
Compare
effectfully
deleted the
effectfully/benchmarking/stop-the-irrelevance-in-full
branch
|
Should we worry about this for the nofib benchmarks too? I'm getting confused because we have lots of different benchmarks that all seem to have their own ways of evaluating terms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #5200, which updated
BenchCek.hsto use the correct evaluation context. This one updatesBenchFull.hs.