Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Unroll an open type family #5845

Closed

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Mar 19, 2024

This PR contains an alternative approach to un-rolling AsData-types: it uses an open type family for it.

This has its own pro:

  • Users are free to specify how to unroll any type (including custom AsData types)
    by provinding a TF instance, for example:
    type instance Unroll AsDataFoo = '[AsDataFoo, Bool, Integer]

and con:

  • There is no default un-rolling of generic types, instead users need to instantiate the Unroll TF for every custom data type:
    type instance Unroll MyGenericFoo = GenericUnroll Foo

@Unisay Unisay force-pushed the yura/PLT-9659/cip57-asData-open-tf branch from d72af58 to 7d9ad01 Compare March 19, 2024 11:40
@Unisay Unisay added the No Changelog Required Add this to skip the Changelog Check label Mar 19, 2024
@Unisay Unisay force-pushed the yura/PLT-9659/cip57-asData branch from 4d0b029 to e13a4cf Compare March 25, 2024 17:38
@Unisay
Copy link
Contributor Author

Unisay commented Mar 25, 2024

Decided not to implement it.

@Unisay Unisay closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant