Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if p then True else False ===> p #5925

Closed
wants to merge 1 commit into from
Closed

if p then True else False ===> p #5925

wants to merge 1 commit into from

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Apr 26, 2024

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@Unisay Unisay self-assigned this Apr 26, 2024
@Unisay
Copy link
Contributor Author

Unisay commented Apr 29, 2024

No golden tests has failed, that suggests the rule is probably never firing, so not that useful.

@Unisay Unisay closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Unisay Unisay

Labels
Don't look here yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Unisay