Add integerToByteString and byteStringToInteger to PlutusV2 at PV10 #6056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
approved these changes
May 17, 2024
Comment on lines
+179
to
+182
| Map.filterWithKey (const . alreadyIntroduced) builtinsIntroducedIn | ||
| where | ||
| builtinAvailableIn :: (PlutusLedgerLanguage, MajorProtocolVersion) -> Bool | ||
| builtinAvailableIn (introducedInLv,introducedInPv) = | ||
| alreadyIntroduced :: (PlutusLedgerLanguage, MajorProtocolVersion) -> Bool | ||
| alreadyIntroduced (introducedInLv,introducedInPv) = |
There was a problem hiding this comment.
Thanks for doing that.
@kwxm you were going to take a look at it, did you manage to do it in the end?
There was a problem hiding this comment.
@kwxm you were going to take a look at it, did you manage to do it in the end?
A look at what?
There was a problem hiding this comment.
At the idea of replacing takeWhileAntitone with filterWithKey here.
There was a problem hiding this comment.
I can see how the highlighted diff and my comment were really confusing. Sorry!
There was a problem hiding this comment.
At the idea of replacing
takeWhileAntitonewithfilterWithKeyhere.
I have no memory of that at all!
There was a problem hiding this comment.
TBH, this whole Versions module needs some rework.
bezirg
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used by e2e testing to verify that adding new builtins to existing ledger languages actually works. Only adding these two for now to make the change minimal; more primitives can be added to V1 and V2 later.