Support testnet #277

edolstra · 2018-09-27T18:44:13Z

This updates the genesis hashes and adds support for non-AVVM balances and the NetworkMagic field in addresses.

It also improves get_block error handling a bit.

NicolasDP

a change of the type to use for the NetworkMagic;
deprecate previous helpers and/or provide new function that takes the NetworkMagic as parameter;
where are the tests for this ?

NicolasDP · 2018-10-03T16:37:43Z

cardano/src/config.rs

@@ -62,6 +63,21 @@ impl cbor_event::Deserialize for ProtocolMagic {
    }
 }

+pub type NetworkMagic = Option<i32>;


I would rather like to use a specific type for this:

pub struct NetworkMagic { NoneRequired, Expected(i32) }

NicolasDP · 2018-10-03T16:38:33Z

cardano/src/config.rs

+            Some(*pm as i32)
+        }
+    }
+}


I think it would be easier to put it, in the configuration of the CLI and hermes.

NicolasDP · 2018-10-03T16:41:06Z

cardano/src/address.rs

@@ -181,25 +182,30 @@ impl cbor_event::de::Deserialize for StakeDistribution {
 #[cfg_attr(feature = "generic-serialization", derive(Serialize, Deserialize))]
 pub struct Attributes {
    pub derivation_path: Option<HDAddressPayload>,
-    pub stake_distribution: StakeDistribution
+    pub stake_distribution: StakeDistribution,
+    pub network_magic: config::NetworkMagic,
    // attr_remains ? whatever...
 }
 impl Attributes {
    pub fn new_bootstrap_era(hdap: Option<HDAddressPayload>) -> Self {


I think we need to update the parameter of these functions to add their NetworkMagic. Or at least to deprecate them (or enable them only for the tests maybe?) so we don't have to do too much rewrite everywhere...

NicolasDP · 2018-10-03T16:46:25Z

I guess the golden tests for the new address are somewhere there for the addresses:

Instead of thread '<unnamed>' panicked at 'index out of bounds: the len is 0 but the index is 0' you now get hermes::service: Sync failed: Requested block 81a965de1412623ccd1cb3664f4d61a6cb4b9d53b44d779ed918e87bf3493f02 does not exist

This was added recently to cardano-sl and is used on the testnet.

This is needed for testnet.

edolstra · 2018-10-11T11:16:51Z

Some updates:

NetworkMagic is now an enum rather than Option<i32>.
The Attributes and ExtendedAddr constructors (and various address generating functions) now require a NetworkMagic argument. cardano-cli will need to be updated for this.
Added a test for encoding/decoding address with NetworkMagic.

NicolasDP · 2018-10-11T15:27:53Z

cardano-c/src/address.rs

    let xpub = unsafe { c_xpubkey.as_ref() }.expect("Not a NULL PTR");
-    let ea = ExtendedAddr::new_simple(xpub.clone());
+    let ea = ExtendedAddr::new_simple(xpub.clone(), NetworkMagic::from(protocol_magic));


no need for this PR. just out of curiosity or knowledge sharing. Did you know you could use Into for everytime you have From implemented ?

This allows you to write things like:

let ea = ExtendedAddr::new_simple(xpub.clone(), protocol_magic.into());

I like the verbose way, less chance to get it wrong. Still less character too.

NicolasDP · 2018-10-11T15:28:50Z

cardano/src/address.rs

+                    // Yes, this is an integer encoded as CBOR encoded as Bytes in CBOR.
+                    let bytes = raw.bytes()?;
+                    let n = RawCbor::from(bytes.bytes()).deserialize::<u32>()?;
+                    network_magic = NetworkMagic::Magic(n);


haskell 😩

sjmackenzie · 2018-11-20T08:21:30Z

We're looking for test net functionality, could you be a dear and merge this?

edolstra · 2018-11-21T15:40:20Z

Synced with master. @NicolasDP @vincenthz Want to merge?

NicolasDP · 2018-12-04T11:22:17Z

@edolstra I cannot merge. This branch does not compile

sjmackenzie · 2018-12-04T15:33:45Z

great chaps, thanks

NicolasDP

thanks

sjmackenzie · 2018-12-04T16:29:26Z

hazzah!

NicolasDP suggested changes Oct 3, 2018

View reviewed changes

NicolasDP added this to In progress in cardano-rust via automation Oct 10, 2018

NicolasDP added this to the V1.0 milestone Oct 10, 2018

NicolasDP added P - high D - medium labels Oct 10, 2018

NicolasDP assigned edolstra Oct 10, 2018

NicolasDP mentioned this pull request Oct 10, 2018

Checked address #290

Merged

edolstra added 10 commits October 11, 2018 11:23

Improve get_block() errors

b9eb170

Instead of thread '<unnamed>' panicked at 'index out of bounds: the len is 0 but the index is 0' you now get hermes::service: Sync failed: Requested block 81a965de1412623ccd1cb3664f4d61a6cb4b9d53b44d779ed918e87bf3493f02 does not exist

Update testnet hashes

5a619fa

address::Attributes: Support NetworkMagic field

6d23ddc

This was added recently to cardano-sl and is used on the testnet.

redeem_pubkey_to_txid(): Emit NetworkMagic

f05daa8

This is needed for testnet.

Support non-AVVM balances

f3144c7

parse_genesis_data(): Support non-AVVM balances

3ec3123

non_avvm_balances: ExtendedAddr -> Addr

42bd303

Turn NetworkMagic into an explicit enum

be28d99

Require network_magic in all functions that construct addresses

0331b11

Add a test for encoding/decoding addresses with network magic

50e2dbb

edolstra force-pushed the support-testnet branch from caed699 to 50e2dbb Compare October 11, 2018 11:13

NicolasDP reviewed Oct 11, 2018

View reviewed changes

NicolasDP approved these changes Oct 11, 2018

View reviewed changes

edolstra added 2 commits November 21, 2018 16:29

Merge remote-tracking branch 'origin/master' into support-testnet

e356a45

Use into()

c0c87e3

Fix test

b9b6588

NicolasDP approved these changes Dec 4, 2018

View reviewed changes

edolstra added 2 commits December 4, 2018 17:02

Merge remote-tracking branch 'origin/master' into support-testnet

5ac2963

Fix test

4ed0d81

NicolasDP approved these changes Dec 4, 2018

View reviewed changes

NicolasDP merged commit 6e4b56e into input-output-hk:master Dec 4, 2018

cardano-rust automation moved this from In progress to Done Dec 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support testnet #277

Support testnet #277

edolstra commented Sep 27, 2018

NicolasDP left a comment

NicolasDP Oct 3, 2018

NicolasDP Oct 3, 2018

NicolasDP Oct 3, 2018

NicolasDP commented Oct 3, 2018 •

edited

edolstra commented Oct 11, 2018

NicolasDP Oct 11, 2018

NicolasDP Oct 11, 2018

sjmackenzie commented Nov 20, 2018

edolstra commented Nov 21, 2018

NicolasDP commented Dec 4, 2018

sjmackenzie commented Dec 4, 2018

NicolasDP left a comment

sjmackenzie commented Dec 4, 2018

Support testnet #277

Support testnet #277

Conversation

edolstra commented Sep 27, 2018

NicolasDP left a comment

Choose a reason for hiding this comment

NicolasDP Oct 3, 2018

Choose a reason for hiding this comment

NicolasDP Oct 3, 2018

Choose a reason for hiding this comment

NicolasDP Oct 3, 2018

Choose a reason for hiding this comment

NicolasDP commented Oct 3, 2018 • edited

edolstra commented Oct 11, 2018

NicolasDP Oct 11, 2018

Choose a reason for hiding this comment

NicolasDP Oct 11, 2018

Choose a reason for hiding this comment

sjmackenzie commented Nov 20, 2018

edolstra commented Nov 21, 2018

NicolasDP commented Dec 4, 2018

sjmackenzie commented Dec 4, 2018

NicolasDP left a comment

Choose a reason for hiding this comment

sjmackenzie commented Dec 4, 2018

NicolasDP commented Oct 3, 2018 •

edited