Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

block genesis finish parsing / printing #90

Closed
vincenthz opened this issue May 21, 2018 · 3 comments · Fixed by #112
Closed

block genesis finish parsing / printing #90

vincenthz opened this issue May 21, 2018 · 3 comments · Fixed by #112

Comments

@vincenthz
Copy link
Member

Finish parsing of genesis blocks (body), and oretty printing of block

@ghost
Copy link

ghost commented May 22, 2018

are you open to using a library for the pretty printing, such as https://docs.rs/pretty/0.4.0/pretty/ ?

@ghost
Copy link

ghost commented May 22, 2018

i guess the answer depends on whether it has dependencies which cannot easily be used in the wasm target.. the pretty library above depends on tempfile but it only uses it for a benchmark.. I'm not sure whether means we cannot use it or not.. i'll assume we cannot for now and see how simple i can make the generic prettyprinter

@NicolasDP NicolasDP assigned ghost May 23, 2018
@NicolasDP NicolasDP added this to TODO in prometheus May 23, 2018
@NicolasDP NicolasDP moved this from TODO to In Progress in prometheus May 23, 2018
@NicolasDP NicolasDP added this to In Progress in cardano-cli May 23, 2018
@ghost
Copy link

ghost commented May 25, 2018

Ok, so there's a generic prettyprinter now. Next steps:

  • bigger todos
    • parse genesis blocks (see how blockchain::normal::Block is parsed)
    • implement Pretty for genesis blocks (use same approach as blockchain::normal::Block implementations)
  • smaller todos
    • add color to previous_hash (field of BlockHeader)
    • add color to block_signature (field of Consensus)
    • extend the AST to allow Val::List<Vec<Value>>, use it for lists like transactions and the long list in genesisblocks

cardano-cli automation moved this from In Progress to Done May 30, 2018
prometheus automation moved this from In Progress to Done May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
cardano-cli
  
Done
prometheus
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant