This repository has been archived by the owner on Jun 11, 2022. It is now read-only.
[IOHKCRB-12] Improve error handling for wallet creation #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecioppettini
force-pushed
the
IOHKCRB-12-improve-error-handling-for-wallet-creation
branch
from
5e254f0
to
b461a72
Compare
ecioppettini
force-pushed
the
IOHKCRB-12-improve-error-handling-for-wallet-creation
branch
from
b461a72
to
6ae5c81
Compare
NicolasDP
approved these changes
Mar 21, 2019
|
Looking good, you might need to rebase your branch. The previous merge (#523 ) seems to have conflict with this one. |
vincenthz
reviewed
Mar 22, 2019
| Ok(e) => e, | ||
| }; | ||
|
|
||
| let wallet = bip44::Wallet::from_entropy(&entropy, &password, hdwallet::DerivationScheme::V2); | ||
|
|
||
| let wallet_box = Box::new(wallet); | ||
| Box::into_raw(wallet_box) | ||
| unsafe { ptr::write(wallet_out, Box::into_raw(wallet_box)) }; |
There was a problem hiding this comment.
might be a good idea to check the wallet_out pointer being non NULL and returning a friendly CardanoResult error if that's the case ?
There was a problem hiding this comment.
I see... The behavior is undefined in that case, wouldn't a panic with a message be better though? I think a null pointer here is most probably a bug in the caller?
Should I always check for null pointers?
vincenthz
approved these changes
Mar 22, 2019
|
Just need rebasing and then we can merge |
ecioppettini
force-pushed
the
IOHKCRB-12-improve-error-handling-for-wallet-creation
branch
from
6ae5c81
to
753aff9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: [IOHKCRB-12] Add test of transaction creation
Description
Error handling
cardano_wallet_newreturn the created wallet as an out parameter and use the return value for the error code. This way it no longer returns a null pointer if the size of the entropy array is not valid.