Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refang excepts in certain cases #3

Closed
rshipp opened this issue May 2, 2018 · 0 comments
Closed

Refang excepts in certain cases #3

rshipp opened this issue May 2, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@rshipp
Copy link
Contributor

rshipp commented May 2, 2018

We do the urlparse try/except before modifiying the URL, which may cause it to error out after we prepend the scheme. Need to just move all the url modifications before the urlparse test.
@rshipp rshipp added the bug Something isn't working label May 2, 2018
@rshipp rshipp added this to To do in Issues May 2, 2018
@rshipp rshipp closed this as completed in f92f9bd May 3, 2018
Issues automation moved this from To do to Done May 3, 2018
@rshipp rshipp removed this from Done in Issues May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rshipp