Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code related to windows isn't extensible #78

Closed
dashdashzako opened this issue May 23, 2019 · 1 comment
Closed

Code related to windows isn't extensible #78

dashdashzako opened this issue May 23, 2019 · 1 comment
Assignees
@dashdashzako
Labels
refactor Something needs refactoring

Comments

@dashdashzako
Copy link
Collaborator

Windows are currently set as a dictionary where each key is a window name, and each value the window settings. This makes manipulating windows list cumbersome, and most of the interactions with this list are either looping through windows or accessing a given window settings.

Using an array would make this much easier, and would also allow adding new windows without having to update types.
@dashdashzako dashdashzako added the refactor Something needs refactoring label May 23, 2019
@dashdashzako dashdashzako self-assigned this May 23, 2019
@dashdashzako
Copy link
Collaborator Author

Fixed by 683e71a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashdashzako dashdashzako

Labels
refactor Something needs refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dashdashzako