Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise M4.04 demo of LinearRegression on repeated features is unstable #641

Closed
ArturoAmorQ opened this issue Jun 22, 2022 · 1 comment · Fixed by #701
Closed

Exercise M4.04 demo of LinearRegression on repeated features is unstable #641

ArturoAmorQ opened this issue Jun 22, 2022 · 1 comment · Fixed by #701
Milestone

Comments

@ArturoAmorQ
Copy link
Collaborator

Originally posted here in the forum. Ridge regression with alpha=1.0 leads to same result as the ordinary linear regression depending on the machine. This is possibly an Issue worth looking at from scikit-learn, but we may alternatively avoid this demo on the MOOC.

Reproducer from OP here: https://gist.github.com/qdpham/21b30181a8e0dd50cfcbba57b61e9b70

@ArturoAmorQ ArturoAmorQ added this to the MOOC 3.0 milestone Sep 7, 2022
@ogrisel ogrisel changed the title Exercise M4.04 demo of Ridge on repeated features is unstable Exercise M4.04 demo of LinearRegression on repeated features is unstable Oct 12, 2022
@ogrisel
Copy link
Collaborator

ogrisel commented Oct 12, 2022

The problem is not with Ridge which always behaves as expected on both machines but rather that LinearRegression does not always fail as we expect it to fail depending on the machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants