Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postProcessingCommand error handling triggers message every time #80

Closed
peskdale opened this issue Jul 9, 2021 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@peskdale
Copy link
Contributor

peskdale commented Jul 9, 2021

Regardless of the actual outcome of a post-processing command, the error message seems to always be triggered after downloading a video.

This can be seen using a very simple command such as echo 'Hello world!'. On further testing, it seems that stderr is defined regardless of outcome, but just empty.

So perhaps there should be an emptiness check too, or the check should instead be run based on non-zero exit status.

@Inrixia
Copy link
Owner

Inrixia commented Jul 9, 2021

This is what I get for not testing properly :)

Ill change the check to a emptiness one rather than if its undefined. I also should have added bar status updates for when its running so Ill do that too.

@Inrixia Inrixia self-assigned this Jul 9, 2021
@Inrixia Inrixia added the bug label Jul 9, 2021
@Inrixia Inrixia added this to To do in Release 5.2.0 via automation Jul 9, 2021
@Inrixia
Copy link
Owner

Inrixia commented Jul 9, 2021

Added in eb62cd2

Please grab the latest dev release and test it to check that the fix is working. The status bar/console should also now indicate when the command is running.

@Inrixia Inrixia added the awaiting fix confirmed Waiting for someone to confirm the fix/change works label Jul 9, 2021
@Inrixia Inrixia moved this from To do to In progress in Release 5.2.0 Jul 9, 2021
@peskdale
Copy link
Contributor Author

peskdale commented Jul 9, 2021

Fix seems to work. Cheers. 👍

@peskdale peskdale closed this as completed Jul 9, 2021
Release 5.2.0 automation moved this from In progress to Done Jul 9, 2021
@Inrixia Inrixia removed the awaiting fix confirmed Waiting for someone to confirm the fix/change works label Jul 9, 2021
@Inrixia Inrixia added this to the Next Release milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants