Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct Code Of Conduct link in README.md #686

Closed
wants to merge 1 commit into from
Closed

fix: use correct Code Of Conduct link in README.md #686

wants to merge 1 commit into from

Conversation

Glazy
Copy link
Contributor

@Glazy Glazy commented Oct 8, 2022

This PR fixes #685 .

  • I've added a unit test to test for potential regressions of this bug. (N/A)
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@Glazy Glazy requested review from a team as code owners October 8, 2022 17:09
@VirginiaBalseiro
Copy link
Contributor

Thank you @Glazy !!

@ThisIsMissEm
Copy link
Contributor

Nice catch! I've raised an internal issue for this as it seems it also affects some other SDK repos.

@NSeydoux NSeydoux mentioned this pull request Oct 10, 2022
Merged
@NSeydoux
Copy link
Contributor

Reapplied in #689

@NSeydoux NSeydoux closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VirginiaBalseiro VirginiaBalseiro VirginiaBalseiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Of Conduct link not working in README.
4 participants
@Glazy @VirginiaBalseiro @ThisIsMissEm @NSeydoux