Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP supports block name #133

Open
bigaru opened this issue Apr 10, 2024 · 1 comment
Open

WP supports block name #133

bigaru opened this issue Apr 10, 2024 · 1 comment
Labels
Milestone

Comments

@bigaru
Copy link
Member

bigaru commented Apr 10, 2024

see https://wordpress.com/support/advanced-block-settings/#block-name

it is stored inside attributes:

{
"metadata" : {
    "name": "my block"
  }
}

so in order to sync between wp blockname and inseri blockname, we simply have to store at metadata.name

@aplamada
Copy link
Member

aplamada commented Apr 11, 2024

At the moment, It is unclear to me whether this is helping or confusing (see below in the print screen). It will "rename" the name that appears in the List View. Maybe the "best" compromise, if feasible, is to let users decide, like "Hide the invisible blocks" with a new option "Update Block Name in List View".
At the same time I think this is the future...

It is unclear to me whether this is a breaking change or not. So far we support WP>5.6 . In case we populate that attribute, can it be that WP 5.7 will complain?

Screenshot 2024-04-11 at 06 50 10

@aplamada aplamada modified the milestone: sprint 18 Apr 11, 2024
@aplamada aplamada added the idea label Apr 11, 2024
@aplamada aplamada added this to the sprint 18 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants