-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not possible to add non-Android module to Android Koin #29
Comments
Hello, Koin 0.7.0 brings a better DSL and Koin modules won't have any dependency with Android classes. Up to you to inject Application/Context dependencies or not. The Wait the next days, for the next release (hope to release it before xmas :) ) |
Great news! |
Sub context is a core feature. You can drop context even if you are not in an Android app. |
I'm working on a new website to give better documentation. Check insert-koin.io next days or our twitter account : |
You can check the Koin 0.7.1 on https://insert-koin.io |
Hi there! Thanks for your hard work on Koin! Great library.
Anyway, I faced an issue, where you force to provide list of
AndroidModule
's toApplication.startKoin()
. Thus it is impossible to provide modules that are built, for example, in data or domain layers, which are usually written without platform dependencies.Briefly looking through your code, I haven't found any serious reason to force
AndroidModule
forandroid
artifact. What do you think? This will be a big win, if yourandroid
artifact'sstartKoin
function will accept all descendants ofModule
.The text was updated successfully, but these errors were encountered: