Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary blacklist sources with unsupported video formats #728

Closed
bwsw opened this issue Apr 10, 2024 · 1 comment · Fixed by #734
Closed

Temporary blacklist sources with unsupported video formats #728

bwsw opened this issue Apr 10, 2024 · 1 comment · Fixed by #734
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bwsw
Copy link
Contributor

bwsw commented Apr 10, 2024

NVDEC supports limited pixel formats for decoders. We must add extra checks and clear reporting to the module and source adapters to report on unsupported colorspaces for NVDEC supported codecs like H264, HEVC, JPEG, VP8, VP9, AV1.

@bwsw bwsw added the enhancement New feature or request label Apr 10, 2024
@bwsw bwsw added this to the 0.4.0 milestone Apr 10, 2024
@bwsw bwsw changed the title Better diagnostic for unsupported colorspaces Better diagnostic for unsupported pixel formats Apr 10, 2024
@tomskikh tomskikh self-assigned this Apr 15, 2024
tomskikh added a commit that referenced this issue Apr 16, 2024
@tomskikh
Copy link
Collaborator

tomskikh commented Apr 17, 2024

@bwsw savant_rs_decode_bin logs the following warnings:

 WARN  insight::savant::savant_rs_video_decode_bin  > Received error from nvv4l2decoder0: gst-resource-error-quark: Failed to process frame. (1). Debug info: gstv4l2videodec.c(2226): gst_v4l2_video_dec_handle_frame (): /GstPipeline:age_gender_recognition/zeromq_source_bin+ZeroMQSourceBin:source/savant_rs_video_decode_bin+SavantRsVideoDecodeBin:savant_rs_video_decode_bin+savantrsvideodecodebin0/GstBin:bin0/GstDecodeBin:decodebin-video2/nvv4l2decoder:nvv4l2decoder0:
Maybe be due to not enough memory or failing driver.
 WARN  insight::savant::savant_rs_video_decode_bin  > Pad nvv4l2decoder0.sink has caps video/x-h264, stream-format=(string)byte-stream, alignment=(string)au, pixel-aspect-ratio=(fraction)1/1, width=(int)1280, height=(int)720, framerate=(fraction)30000/1001, chroma-format=(string)4:4:4, bit-depth-luma=(uint)10, bit-depth-chroma=(uint)10, colorimetry=(string)bt709, parsed=(boolean)true, profile=(string)high-4:4:4, level=(string)3.1
 WARN  insight::savant::savant_rs_video_decode_bin  > Pad nvv4l2decoder0.src has caps None

savant_rs_video_demux puts the source in the quarantine to skip frames with this source ID. The quarantine timeout is configurable, 10 seconds by default.

tomskikh added a commit that referenced this issue Apr 17, 2024
@tomskikh tomskikh linked a pull request Apr 17, 2024 that will close this issue
@bwsw bwsw changed the title Better diagnostic for unsupported pixel formats Temporary blacklist sources with unsupported video formats Apr 17, 2024
tomskikh added a commit that referenced this issue Apr 18, 2024
tomskikh added a commit that referenced this issue Apr 18, 2024
* #728 handle decoder errors

* #728 log caps in case of error

* #728 set default quarantine timeout to 10 seconds

* #728 use source blacklist from savant-rs

* #728 update savant-rs to 0.2.26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants