Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXT01 and LBT01 UAT feedback #88

Closed
4 of 6 tasks
BFalquet opened this issue Nov 8, 2021 · 3 comments
Closed
4 of 6 tasks

EXT01 and LBT01 UAT feedback #88

BFalquet opened this issue Nov 8, 2021 · 3 comments
Assignees

Comments

@BFalquet
Copy link
Contributor

BFalquet commented Nov 8, 2021

EXT01

  • Example shown in vignette is not accurate, also ANL01FL is not relevant subset
    (see n, maybe filter by drug in PARCAT2, one table by drug)
    (filter for PARCAT1 == "OVERALL" )
  • How are we defining the variables to include? Is this by user filtering?
    => filtered inside the function (for now)
  • I do not understand EXT01_2, think we need a rethink on how AVALCAT is included?

LBT01

  • Missing N in treatment header
    => should be under ACTARM (not CHG or AVAL)
  • How is precision controlled/will be controlled? Different tests require different precision
    => add info to study object ?
    "A reasonable level of precision for means, SDs, and medians is one digit more than the level of precision of the test. Present the minimum and maximum to the level of precision of the test."
  • Column headers do not match standard
@BFalquet BFalquet self-assigned this Nov 8, 2021
@barnett11
Copy link
Contributor

EXT01.pdf

@BFalquet - I had a think about EXT01 and provided file shows what should be default for EXT01, with ability to include the further optional rows. The rows labelled EXAMPLE are important for us to showcase in vignette as they are most common additions. I think this should all be achieved in EXT01_1, rather than separate _2 for this?

@BFalquet
Copy link
Contributor Author

I see that treatment duration (time limit) is a categorical value that doesn't really fit in the current paradigm of ext01_1 but would work in ext01_2.
Would inverting ext01 and ext02 do the trick (with minor modifications)?

@waddella
Copy link
Contributor

has been solved in refactor and issues for delta were created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants