Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staged.deps #304

Closed
nikolas-burkoff opened this issue Mar 4, 2022 · 1 comment · Fixed by #305
Closed

Update staged.deps #304

nikolas-burkoff opened this issue Mar 4, 2022 · 1 comment · Fixed by #305

Comments

@nikolas-burkoff
Copy link

nikolas-burkoff commented Mar 4, 2022

Hi - can you create a branch named 130_reorg@main and replace the downstream dependency on teal.devel with teal.widgets please - i.e. replace:

    insightsengineering/teal.devel:
    repo: insightsengineering/teal.devel
    host: https://github.com

with

  insightsengineering/teal.widgets:
    repo: insightsengineering/teal.widgets
    host: https://github.com

And then when the rest of the merge is ready we can merge this PR in.

The right answer is (?) for NEST to have rtables as an external dependency not an internal one but in the mean time, there may be questions like this.

@gmbecker - can you do this and maybe add branch creation rights to some of the NEST developers?

@pawelru pawelru linked a pull request Mar 11, 2022 that will close this issue
@pawelru
Copy link
Contributor

pawelru commented Mar 11, 2022

already done

@pawelru pawelru closed this as completed Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants